Adds a patchfile for fsevents #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you get the PR to our fsevents repo? We will discuss it there! |
|
Though I have to say that fsevents seems like the worst possible layer to do this. |
|
Damn, for some reasons |
|
Oh interesting - FSEvents 2.x works on GitHub Actions, but not 1.x 🤔 |
|
Errata: I had a typo in the variable name that was causing |
|
Merging for now, will open a PR against FSEvents later. |
1 task
bpierre
added a commit
to aragon/court-dashboard
that referenced
this pull request
Feb 6, 2020
Waiting for copy-aragon-ui-assets to be compatible with PnP. Also waiting for the next yarn version to be released to get this fix: yarnpkg/berry#692 Alternatively, we could upgrade react-scripts.
bpierre
added a commit
to aragon/court-dashboard
that referenced
this pull request
Feb 6, 2020
Waiting for copy-aragon-ui-assets to be compatible with PnP. Also waiting for the next yarn version to be released to get this fix: yarnpkg/berry#692 Alternatively, we could upgrade react-scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
FsEvents isn't aware of the virtual filesystem (
$$virtual, more details at the end of this post), and that breaks Webpack when requiring files from a workspace that lists peer dependencies.How did you fix it?
As a short-term fix I've implemented the fix in
fseventsvia our newpatch:protocol. I wonder if we could convince thefseventsmaintainers to merge the change upstream? (cc @paulmillr / @pipobscure)What is this
$$virtualthing?First read that. Now, as the article says:
The way we do this by injecting a
fslayer that applies the following algorithm:/$$virtual/<whatever>/<number>/'../'.repeat(number)So for example,
/foo/$$virtual/abcdef/0/hellobecomes/foo/hello, and/foo/$$virtual/abcdef/1/hellobecomes/hello. This technic allows us to generate an infinity of paths for a given package.